This is true - there is a shortage of long term lets in some parts now as more and more owners see short term tourist lets as more lucrative. Ordinary (Spanish) people are being squeezed out of popular areas and there have been incidents of 'turismofobia' in reaction to the adverse effects than increased tourism is having. Another thing which makes things perhaps less attractive in Spain now is the pensions crisis. It used to be the case that if you worked here for long enough you'd be rewarded with a pretty generous pension at the end of it which would compensate to some degree for not having been able to save as much as if you'd worked somewhere better paying. But the pensions pot is empty and the government is currently looking to 'recalculate' pensions so this can not be relied on any more. Think very carefully about whether you can really afford it before you accept a job in Spain.